Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-03 Thread Michael S. Tsirkin
On Fri, Mar 03, 2023 at 10:08:17AM +0100, Eugenio Perez Martin wrote: > On Fri, Mar 3, 2023 at 12:31 AM Michael S. Tsirkin wrote: > > > > On Thu, Mar 02, 2023 at 03:47:48PM +0100, Eugenio Perez Martin wrote: > > > On Thu, Mar 2, 2023 at 12:43 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-03 Thread Eugenio Perez Martin
On Fri, Mar 3, 2023 at 12:31 AM Michael S. Tsirkin wrote: > > On Thu, Mar 02, 2023 at 03:47:48PM +0100, Eugenio Perez Martin wrote: > > On Thu, Mar 2, 2023 at 12:43 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Mar 02, 2023 at 12:30:52PM +0100, Eugenio Perez Martin wrote: > > > > > You need to

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-02 Thread Michael S. Tsirkin
On Thu, Mar 02, 2023 at 03:47:48PM +0100, Eugenio Perez Martin wrote: > On Thu, Mar 2, 2023 at 12:43 PM Michael S. Tsirkin wrote: > > > > On Thu, Mar 02, 2023 at 12:30:52PM +0100, Eugenio Perez Martin wrote: > > > > You need to pass this to guest. My point is that there is no reason to > > > > get

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-02 Thread Eugenio Perez Martin
On Thu, Mar 2, 2023 at 12:43 PM Michael S. Tsirkin wrote: > > On Thu, Mar 02, 2023 at 12:30:52PM +0100, Eugenio Perez Martin wrote: > > > You need to pass this to guest. My point is that there is no reason to > > > get it from the kernel driver. QEMU can figure out whether the flag is > > > needed

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-02 Thread Michael S. Tsirkin
On Thu, Mar 02, 2023 at 12:30:52PM +0100, Eugenio Perez Martin wrote: > > You need to pass this to guest. My point is that there is no reason to > > get it from the kernel driver. QEMU can figure out whether the flag is > > needed itself. > > > > Ok, I can see now how the HW device does not have a

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-02 Thread Eugenio Perez Martin
On Wed, Mar 1, 2023 at 10:37 PM Michael S. Tsirkin wrote: > > On Tue, Feb 14, 2023 at 09:36:01AM +0100, Eugenio Perez Martin wrote: > > On Tue, Feb 14, 2023 at 8:51 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Feb 14, 2023 at 08:02:08AM +0100, Eugenio Perez Martin wrote: > > > > On Tue, Feb 1

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-03-01 Thread Michael S. Tsirkin
On Tue, Feb 14, 2023 at 09:36:01AM +0100, Eugenio Perez Martin wrote: > On Tue, Feb 14, 2023 at 8:51 AM Michael S. Tsirkin wrote: > > > > On Tue, Feb 14, 2023 at 08:02:08AM +0100, Eugenio Perez Martin wrote: > > > On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote: > > > > > > > > On Tue, Feb 14, 2

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-02-14 Thread Jason Wang
On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote: > > VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and > the device are ordered in a way described by the platform. Since vDPA > devices may be backed by a hardware devices, let's allow > VIRTIO_F_ORDER_PLATFORM. > > Signe

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-02-14 Thread Eugenio Perez Martin
On Tue, Feb 14, 2023 at 8:51 AM Michael S. Tsirkin wrote: > > On Tue, Feb 14, 2023 at 08:02:08AM +0100, Eugenio Perez Martin wrote: > > On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote: > > > > > > On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote: > > > > > > > > VIRTIO_F_ORDER_PLATFORM indic

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-02-14 Thread Michael S. Tsirkin
On Tue, Feb 14, 2023 at 08:02:08AM +0100, Eugenio Perez Martin wrote: > On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote: > > > > On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote: > > > > > > VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and > > > the device are ordered

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-02-14 Thread Eugenio Perez Martin
On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote: > > On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote: > > > > VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and > > the device are ordered in a way described by the platform. Since vDPA > > devices may be backed by a har

[PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

2023-02-13 Thread Eugenio Pérez
VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and the device are ordered in a way described by the platform. Since vDPA devices may be backed by a hardware devices, let's allow VIRTIO_F_ORDER_PLATFORM. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c |