Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-19 Thread Stefan Hajnoczi
On Wed, 19 Jul 2023 at 09:34, Hanna Czenczek wrote: > > On 18.07.23 17:26, Stefan Hajnoczi wrote: > > On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: > >> Currently, the vhost-user documentation says that rings are to be > >> initialized in a disabled state when

Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-19 Thread Hanna Czenczek
On 18.07.23 17:26, Stefan Hajnoczi wrote: On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: Currently, the vhost-user documentation says that rings are to be initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is negotiated. However, by the time of feature

Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-18 Thread Stefan Hajnoczi
On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: > Currently, the vhost-user documentation says that rings are to be > initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is > negotiated. However, by the time of feature negotiation, all rings have > already been

Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-12 Thread Hanna Czenczek
On 12.07.23 13:17, Michael S. Tsirkin wrote: On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: Currently, the vhost-user documentation says that rings are to be initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is negotiated. However, by the time of feature

Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-12 Thread Michael S. Tsirkin
On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: > Currently, the vhost-user documentation says that rings are to be > initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is > negotiated. However, by the time of feature negotiation, all rings have > already been

[PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-12 Thread Hanna Czenczek
Currently, the vhost-user documentation says that rings are to be initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is negotiated. However, by the time of feature negotiation, all rings have already been initialized, so it is not entirely clear what this means. At least the