Re: [PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-31 Thread Jason Wang
On Sat, Oct 29, 2022 at 1:28 AM Si-Wei Liu wrote: > > Hi Jason, > > This one is a one-line simple bug fix but seems to be missed from the pull > request. If there's a v2 for the PULL, would appreciate if you can piggyback. > Thanks in advance! > > Regards, > -Siwei > I've queued this for rc1.

Re: [PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-28 Thread Si-Wei Liu
Hi Jason, This one is a one-line simple bug fix but seems to be missed from the pull request. If there's a v2 for the PULL, would appreciate if you can piggyback. Thanks in advance! Regards, -Siwei On 10/7/2022 8:42 AM, Eugenio Perez Martin wrote: On Tue, Oct 4, 2022 at 11:05 PM Si-Wei Liu

Re: [PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-07 Thread Eugenio Perez Martin
On Tue, Oct 4, 2022 at 11:05 PM Si-Wei Liu wrote: > > The citing commit has incorrect code in vhost_vdpa_receive() that returns > zero instead of full packet size to the caller. This renders pending packets > unable to be freed so then get clogged in the tx queue forever. When device > is being

Re: [PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-04 Thread Si-Wei Liu
Apologies, please disregard this email. Wrong target audience it was sent to, although the content of patch is correct. For those who want to review the patch, please reply to this thread: Message-Id: <1664913563-3351-1-git-send-email-si-wei@oracle.com> Thanks, -Siwei On 10/4/2022 12:58

[PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-04 Thread Si-Wei Liu
The citing commit has incorrect code in vhost_vdpa_receive() that returns zero instead of full packet size to the caller. This renders pending packets unable to be freed so then get clogged in the tx queue forever. When device is being reset later on, below assertion failure ensues: 0

[PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-04 Thread Si-Wei Liu
The citing commit has incorrect code in vhost_vdpa_receive() that returns zero instead of full packet size to the caller. This renders pending packets unable to be freed so then get clogged in the tx queue forever. When device is being reset later on, below assertion failure ensues: 0