Re: [PATCH] virtio: Always reset vhost devices

2024-07-11 Thread Hanna Czenczek
On 10.07.24 18:28, Stefan Hajnoczi wrote: On Wed, 10 Jul 2024 at 13:25, Hanna Czenczek wrote: Requiring `vhost_started` to be true for resetting vhost devices in `virtio_reset()` seems like the wrong condition: Most importantly, the preceding `virtio_set_status(vdev, 0)` call will (for vhost de

Re: [PATCH] virtio: Always reset vhost devices

2024-07-11 Thread Hanna Czenczek
On 10.07.24 15:39, Matias Ezequiel Vara Larsen wrote: Hello Hanna, On Wed, Jul 10, 2024 at 01:23:10PM +0200, Hanna Czenczek wrote: Requiring `vhost_started` to be true for resetting vhost devices in `virtio_reset()` seems like the wrong condition: Most importantly, the preceding `virtio_set_sta

Re: [PATCH] virtio: Always reset vhost devices

2024-07-10 Thread Stefan Hajnoczi
On Wed, 10 Jul 2024 at 13:25, Hanna Czenczek wrote: > > Requiring `vhost_started` to be true for resetting vhost devices in > `virtio_reset()` seems like the wrong condition: Most importantly, the > preceding `virtio_set_status(vdev, 0)` call will (for vhost devices) end > up in `vhost_dev_stop()`

Re: [PATCH] virtio: Always reset vhost devices

2024-07-10 Thread Matias Ezequiel Vara Larsen
Hello Hanna, On Wed, Jul 10, 2024 at 01:23:10PM +0200, Hanna Czenczek wrote: > Requiring `vhost_started` to be true for resetting vhost devices in > `virtio_reset()` seems like the wrong condition: Most importantly, the > preceding `virtio_set_status(vdev, 0)` call will (for vhost devices) end > u

[PATCH] virtio: Always reset vhost devices

2024-07-10 Thread Hanna Czenczek
Requiring `vhost_started` to be true for resetting vhost devices in `virtio_reset()` seems like the wrong condition: Most importantly, the preceding `virtio_set_status(vdev, 0)` call will (for vhost devices) end up in `vhost_dev_stop()` (through vhost devices' `.set_status` implementations), settin