Re: [PATCH] virtio: fix reachable assertion due to stale value of cached region size

2023-03-02 Thread Carlos López
Hi, On 1/3/23 23:03, Michael S. Tsirkin wrote:>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index f35178f5fc..db70c4976e 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -1071,6 +1071,7 @@ static void virtqueue_split_get_avail_bytes(VirtQueue *vq, VirtIODevice *vdev =

Re: [PATCH] virtio: fix reachable assertion due to stale value of cached region size

2023-03-01 Thread Jason Wang
On Thu, Feb 16, 2023 at 6:23 AM Carlos López wrote: > > In virtqueue_{split,packed}_get_avail_bytes() descriptors are read > in a loop via MemoryRegionCache regions and calls to > vring_{split,packed}_desc_read() - these take a region cache and the > index of the descriptor to be read. > > For dir

Re: [PATCH] virtio: fix reachable assertion due to stale value of cached region size

2023-03-01 Thread Michael S. Tsirkin
On Wed, Feb 15, 2023 at 11:14:46PM +0100, Carlos López wrote: > In virtqueue_{split,packed}_get_avail_bytes() descriptors are read > in a loop via MemoryRegionCache regions and calls to > vring_{split,packed}_desc_read() - these take a region cache and the > index of the descriptor to be read. > >

[PATCH] virtio: fix reachable assertion due to stale value of cached region size

2023-02-15 Thread Carlos López
In virtqueue_{split,packed}_get_avail_bytes() descriptors are read in a loop via MemoryRegionCache regions and calls to vring_{split,packed}_desc_read() - these take a region cache and the index of the descriptor to be read. For direct descriptors we use a cache provided by the caller, whose size