Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-02-14 Thread Eugenio Perez Martin
On Tue, Jan 24, 2023 at 5:32 PM Eugenio Pérez wrote: > > Since GUEST_ANNOUNCE is emulated the feature bit could be set without > backend support. This happens in the vDPA case. > > However, backend vDPA parent may not have CVQ support. This causes an > incoherent feature set, and the driver may

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-02-14 Thread Lei Yang
QE uses the sim_vdpa device to test this patch and add "ctrl_vq=off" in the qemu command line. Guest can find this device, there are no any error messages in guest dmesg, and can migrate successfully. Tested-by: Lei Yang Eugenio Perez Martin 于2023年2月14日周二 14:53写道: > > On Tue, Jan 24, 2023 at

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-01-27 Thread Gautam Dawar
On 1/25/23 21:22, Eugenio Perez Martin wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Wed, Jan 25, 2023 at 4:20 PM David Edmondson wrote: On Tuesday, 2023-01-24 at 17:11:59 +01, Eugenio Pérez

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-01-25 Thread Eugenio Perez Martin
On Wed, Jan 25, 2023 at 4:20 PM David Edmondson wrote: > > On Tuesday, 2023-01-24 at 17:11:59 +01, Eugenio Pérez wrote: > > Since GUEST_ANNOUNCE is emulated the feature bit could be set without > > backend support. This happens in the vDPA case. > > > > However, backend vDPA parent may not have

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-01-25 Thread David Edmondson
On Tuesday, 2023-01-24 at 17:11:59 +01, Eugenio Pérez wrote: > Since GUEST_ANNOUNCE is emulated the feature bit could be set without > backend support. This happens in the vDPA case. > > However, backend vDPA parent may not have CVQ support. This causes an > incoherent feature set, and the

[PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-01-24 Thread Eugenio Pérez
Since GUEST_ANNOUNCE is emulated the feature bit could be set without backend support. This happens in the vDPA case. However, backend vDPA parent may not have CVQ support. This causes an incoherent feature set, and the driver may refuse to start. This happens in virtio-net Linux driver. This