Re: [PATCH] virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

2022-01-26 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Jan 25, 2022 at 01:51:14PM -0500, Vivek Goyal wrote: > > At the start, drop membership of all supplementary groups. This is > > not required. > > > > If we have membership of "root" supplementary group and when we switch > > uid/gid using se

Re: [PATCH] virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

2022-01-26 Thread Stefan Hajnoczi
On Tue, Jan 25, 2022 at 01:51:14PM -0500, Vivek Goyal wrote: > At the start, drop membership of all supplementary groups. This is > not required. > > If we have membership of "root" supplementary group and when we switch > uid/gid using setresuid/setsgid, we still retain membership of existing > s

[PATCH] virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

2022-01-25 Thread Vivek Goyal
At the start, drop membership of all supplementary groups. This is not required. If we have membership of "root" supplementary group and when we switch uid/gid using setresuid/setsgid, we still retain membership of existing supplemntary groups. And that can allow some operations which are not norm