Re: [PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-06 Thread Gerd Hoffmann
On Tue, Sep 06, 2022 at 12:27:25PM +0200, Jason A. Donenfeld wrote: > Hi Gerd, > > On Mon, Sep 5, 2022 at 10:40 AM Gerd Hoffmann wrote: > > > > On Sun, Sep 04, 2022 at 06:50:58PM +0200, Jason A. Donenfeld wrote: > > > This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), and > > >

Re: [PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-06 Thread Jason A. Donenfeld
Hi Gerd, On Mon, Sep 5, 2022 at 10:40 AM Gerd Hoffmann wrote: > > On Sun, Sep 04, 2022 at 06:50:58PM +0200, Jason A. Donenfeld wrote: > > This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), and > > then makes the use of setup_data safe. It does so by checking the boot > > protoco

Re: [PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-05 Thread Gerd Hoffmann
On Sun, Sep 04, 2022 at 06:50:58PM +0200, Jason A. Donenfeld wrote: > This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), and > then makes the use of setup_data safe. It does so by checking the boot > protocol version. If it's sufficient, then it means EFI boots won't > crash. Whil

Re: [PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-04 Thread Jason A. Donenfeld
FYI, this patch depends on this one in the kernel: https://lore.kernel.org/linux-efi/20220904165321.1140894-1-ja...@zx2c4.com/

[PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-04 Thread Jason A. Donenfeld
This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), and then makes the use of setup_data safe. It does so by checking the boot protocol version. If it's sufficient, then it means EFI boots won't crash. While we're at it, gate this on SEV too. Cc: Gerd Hoffmann Cc: Laurent Vivier