Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-23 Thread Markus Armbruster
Thomas Huth writes: > On 16/03/2021 14.59, Markus Armbruster wrote: >> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though >> their external symbols conflict. The linker happens to pick the >> former. This links a bunch of unneeded code into the executables that >> actually want

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-22 Thread Thomas Huth
On 16/03/2021 14.59, Markus Armbruster wrote: util/yank.c and stubs/yank.c are both in libqemuutil.a, even though their external symbols conflict. The linker happens to pick the former. This links a bunch of unneeded code into the executables that actually want the latter: qemu-io, qemu-img, qe

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-17 Thread Lukas Straub
On Tue, 16 Mar 2021 14:59:07 +0100 Markus Armbruster wrote: > util/yank.c and stubs/yank.c are both in libqemuutil.a, even though > their external symbols conflict. The linker happens to pick the > former. This links a bunch of unneeded code into the executables that > actually want the latter:

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-16 Thread Markus Armbruster
Eric Blake writes: > On 3/16/21 8:59 AM, Markus Armbruster wrote: >> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though >> their external symbols conflict. The linker happens to pick the >> former. This links a bunch of unneeded code into the executables that >> actually want t

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-16 Thread Markus Armbruster
Eric Blake writes: > On 3/16/21 8:59 AM, Markus Armbruster wrote: >> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though >> their external symbols conflict. The linker happens to pick the >> former. This links a bunch of unneeded code into the executables that >> actually want t

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-16 Thread Eric Blake
On 3/16/21 8:59 AM, Markus Armbruster wrote: > util/yank.c and stubs/yank.c are both in libqemuutil.a, even though > their external symbols conflict. The linker happens to pick the > former. This links a bunch of unneeded code into the executables that > actually want the latter: qemu-io, qemu-im

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-16 Thread Eric Blake
On 3/16/21 8:59 AM, Markus Armbruster wrote: > util/yank.c and stubs/yank.c are both in libqemuutil.a, even though > their external symbols conflict. The linker happens to pick the > former. This links a bunch of unneeded code into the executables that > actually want the latter: qemu-io, qemu-im

[PATCH] yank: Avoid linking into executables that don't want it

2021-03-16 Thread Markus Armbruster
util/yank.c and stubs/yank.c are both in libqemuutil.a, even though their external symbols conflict. The linker happens to pick the former. This links a bunch of unneeded code into the executables that actually want the latter: qemu-io, qemu-img, qemu-nbd, and several tests. Amazingly, none of t