Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since a010bdbe719 the gdbstub API takes a GByteArray*. > Unfortunately we forgot to update the gdb_get_reg*() > calls. Do it now. > Queued to for-5.0/more-random-fixes, thanks. > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > Reported-by:

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Peter Xu
On Thu, Apr 09, 2020 at 08:36:22PM +0200, Laurent Vivier wrote: > Le 09/04/2020 à 20:22, Peter Xu a écrit : > > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: > >> Since a010bdbe719 the gdbstub API takes a GByteArray*. > >> Unfortunately we forgot to update the gdb_get_reg*

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Laurent Vivier
Le 09/04/2020 à 20:22, Peter Xu a écrit : > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: >> Since a010bdbe719 the gdbstub API takes a GByteArray*. >> Unfortunately we forgot to update the gdb_get_reg*() >> calls. Do it now. >> >> Fixes: a010bdbe719 ("extend GByteArray to

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Laurent Vivier
Le 09/04/2020 à 20:22, Peter Xu a écrit : > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: >> Since a010bdbe719 the gdbstub API takes a GByteArray*. >> Unfortunately we forgot to update the gdb_get_reg*() >> calls. Do it now. >> >> Fixes: a010bdbe719 ("extend GByteArray to

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Peter Xu
On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: > Since a010bdbe719 the gdbstub API takes a GByteArray*. > Unfortunately we forgot to update the gdb_get_reg*() > calls. Do it now. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Should this be instead

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Laurent Vivier
Le 09/04/2020 à 19:25, Philippe Mathieu-Daudé a écrit : > Since a010bdbe719 the gdbstub API takes a GByteArray*. > Unfortunately we forgot to update the gdb_get_reg*() > calls. Do it now. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > Reported-by: Peter Xu > Signed-off-b

[PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Philippe Mathieu-Daudé
Since a010bdbe719 the gdbstub API takes a GByteArray*. Unfortunately we forgot to update the gdb_get_reg*() calls. Do it now. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Reported-by: Peter Xu Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20200409164954.36902-1-pet..