Re: [PATCH-for-5.2] hw/smbios: Fix leaked fd in save_opt_one() error path

2020-11-02 Thread Laszlo Ersek
On 10/30/20 16:27, Philippe Mathieu-Daudé wrote: > Fix the following Coverity issue (RESOURCE_LEAK): > > CID 1432879: Resource leak > > Handle variable fd going out of scope leaks the handle. > > Replace a close() call by qemu_close() since the handle is > opened with qemu_open(). > > Fix

Re: [PATCH-for-5.2] hw/smbios: Fix leaked fd in save_opt_one() error path

2020-11-02 Thread Stefano Garzarella
On Fri, Oct 30, 2020 at 04:27:42PM +0100, Philippe Mathieu-Daudé wrote: Fix the following Coverity issue (RESOURCE_LEAK): CID 1432879: Resource leak Handle variable fd going out of scope leaks the handle. Replace a close() call by qemu_close() since the handle is opened with qemu_open().

[PATCH-for-5.2] hw/smbios: Fix leaked fd in save_opt_one() error path

2020-10-30 Thread Philippe Mathieu-Daudé
Fix the following Coverity issue (RESOURCE_LEAK): CID 1432879: Resource leak Handle variable fd going out of scope leaks the handle. Replace a close() call by qemu_close() since the handle is opened with qemu_open(). Fixes: bb99f4772f5 ("hw/smbios: support loading OEM strings values from