Re: [PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-12 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Jul 09, 2020 at 15:13:22 +0100, Alex Bennée wrote: >> While there isn't any easy way to make the inline counts thread safe > > Why not? At least in 64-bit hosts TCG will emit a single write to > update the 64-bit counter. Well the operation is an add so that is

Re: [PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-11 Thread Emilio G. Cota
On Thu, Jul 09, 2020 at 15:13:22 +0100, Alex Bennée wrote: > While there isn't any easy way to make the inline counts thread safe Why not? At least in 64-bit hosts TCG will emit a single write to update the 64-bit counter. > we can ensure the callback based ones are. While we are at it we can > r

Re: [PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-09 Thread Robert Foley
Reviewed-by: Robert Foley On Thu, 9 Jul 2020 at 10:13, Alex Bennée wrote: > > While there isn't any easy way to make the inline counts thread safe > we can ensure the callback based ones are. While we are at it we can > reduce introduce a new option ("idle") to dump a report of the current > bb

[PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-09 Thread Alex Bennée
While there isn't any easy way to make the inline counts thread safe we can ensure the callback based ones are. While we are at it we can reduce introduce a new option ("idle") to dump a report of the current bb and insn count each time a vCPU enters the idle state. Signed-off-by: Alex Bennée Cc: