Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-23 Thread Prasad Pandit
Hi, On Tue, 23 Jul 2024 at 10:33, Prasad Pandit wrote: > On Sun, 21 Jul 2024 at 01:11, Michael S. Tsirkin wrote: > > > > > On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > > > > > > I just want to understand how we managed to have two threads > > > > > > talking in parallel.

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-23 Thread Peter Xu
On Tue, Jul 23, 2024 at 10:33:58AM +0530, Prasad Pandit wrote: > On Sun, 21 Jul 2024 at 01:11, Michael S. Tsirkin wrote: > > > > > On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > > > > > > I just want to understand how we managed to have two threads > > > > > > talking in par

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-22 Thread Prasad Pandit
On Sun, 21 Jul 2024 at 01:11, Michael S. Tsirkin wrote: > > > > On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > > > > > I just want to understand how we managed to have two threads > > > > > talking in parallel. BQL is normally enough, which path > > > > > manages to invoke v

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-20 Thread Michael S. Tsirkin
On Wed, Jul 17, 2024 at 09:47:17AM -0400, Peter Xu wrote: > On Wed, Jul 17, 2024 at 09:40:06AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 17, 2024 at 09:33:01AM -0400, Peter Xu wrote: > > > Hi, Michael, > > > > > > On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > > > > I

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-17 Thread Peter Xu
On Wed, Jul 17, 2024 at 09:40:06AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 17, 2024 at 09:33:01AM -0400, Peter Xu wrote: > > Hi, Michael, > > > > On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > > > I just want to understand how we managed to have two threads > > > talk

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-17 Thread Michael S. Tsirkin
On Wed, Jul 17, 2024 at 09:33:01AM -0400, Peter Xu wrote: > Hi, Michael, > > On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > > I just want to understand how we managed to have two threads > > talking in parallel. BQL is normally enough, which path > > manages to invoke vhost-

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-17 Thread Peter Xu
Hi, Michael, On Wed, Jul 17, 2024 at 04:55:52AM -0400, Michael S. Tsirkin wrote: > I just want to understand how we managed to have two threads > talking in parallel. BQL is normally enough, which path > manages to invoke vhost-user with BQL not taken? > Just check BQL taken on each vhost user inv

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-17 Thread Michael S. Tsirkin
On Tue, Jul 16, 2024 at 06:02:50PM -0400, Peter Xu wrote: > On Tue, Jul 16, 2024 at 03:44:54PM +0530, Prasad Pandit wrote: > > Hello Peter, > > > > On Mon, 15 Jul 2024 at 19:10, Peter Xu wrote: > > > IMHO it's better we debug and fix all the issues before merging this one, > > > otherwise we may

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-16 Thread Peter Xu
On Tue, Jul 16, 2024 at 03:44:54PM +0530, Prasad Pandit wrote: > Hello Peter, > > On Mon, 15 Jul 2024 at 19:10, Peter Xu wrote: > > IMHO it's better we debug and fix all the issues before merging this one, > > otherwise we may overlook something. > > * Well we don't know where the issue is, not

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-16 Thread Prasad Pandit
Hello Peter, On Mon, 15 Jul 2024 at 19:10, Peter Xu wrote: > IMHO it's better we debug and fix all the issues before merging this one, > otherwise we may overlook something. * Well we don't know where the issue is, not sure where the fix may go in, ex. if the issue turns out to be how virsh(1) i

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-15 Thread Peter Xu
On Mon, Jul 15, 2024 at 03:44:06PM +0530, Prasad Pandit wrote: > > I remember after you added the rwlock, there's still a hang issue. > > Did you investigated that? Or do you mean this series will fix all the > > problems? > > * No, this series does not fix the guest hang issue. Root cause of >

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-15 Thread Prasad Pandit
On Thu, 11 Jul 2024 at 21:08, Peter Xu wrote: > Hmm, I thought it was one of the vcpu threads that invoked > vhost_dev_start(), rather than any migration thread? [QEMU=vhost-user-front-end] <===> [QEMU=vhost-user-front-end] ^

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-11 Thread Peter Xu
On Thu, Jul 11, 2024 at 06:44:22PM +0530, Prasad Pandit wrote: > From: Prasad Pandit > > Hello, > > * virsh(1) offers multiple options to initiate Postcopy migration: > > 1) virsh migrate --postcopy --postcopy-after-precopy > 2) virsh migrate --postcopy + virsh migrate-postcopy > 3)

[PATCH 0/2] Postcopy migration and vhost-user errors

2024-07-11 Thread Prasad Pandit
From: Prasad Pandit Hello, * virsh(1) offers multiple options to initiate Postcopy migration: 1) virsh migrate --postcopy --postcopy-after-precopy 2) virsh migrate --postcopy + virsh migrate-postcopy 3) virsh migrate --postcopy --timeout --timeout-postcopy When Postcopy migration