Re: [PATCH 0/2] build qxl as module

2020-06-04 Thread Gerd Hoffmann
> Other candidates: > * virtio-gpu (libvirglrenderer.so). > * ccid-card-emulated (libcacard.so). * usb-redir (libusbredir.so) * usb-host (libusb.so) usb-host also has a monitor command ("info usbhost"). This uses libusb too so leaving that in core qemu would be pointless. So for that one

Re: [PATCH 0/2] build qxl as module

2020-06-04 Thread Gerd Hoffmann
On Thu, Jun 04, 2020 at 09:48:20AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 04, 2020 at 09:59:41AM +0200, Gerd Hoffmann wrote: > > > > There's no info here, or in the commit message about the > intended goal of this modularization ? If we're modularizing > devices, why only qxl and not

Re: [PATCH 0/2] build qxl as module

2020-06-04 Thread Daniel P . Berrangé
On Thu, Jun 04, 2020 at 09:59:41AM +0200, Gerd Hoffmann wrote: > There's no info here, or in the commit message about the intended goal of this modularization ? If we're modularizing devices, why only qxl and not other devices too ? > > Gerd Hoffmann (2): > qdev: add support for device module

Re: [PATCH 0/2] build qxl as module

2020-06-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200604075943.7001-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH 0/2] build qxl as module

2020-06-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200604075943.7001-1-kra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH 0/2] build qxl as module

2020-06-04 Thread Gerd Hoffmann
Gerd Hoffmann (2): qdev: add support for device module loading vga: build qxl as module Makefile.objs| 1 + Makefile.target | 7 ++ include/hw/qdev-core.h | 3 +++ include/qemu/module.h| 1 + hw/core/qdev.c | 49