Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-23 Thread Kevin Wolf
Am 22.06.2020 um 17:50 hat Nir Soffer geschrieben: > On Mon, Jun 22, 2020 at 12:47 PM Max Reitz wrote: > > > > On 22.06.20 00:25, Nir Soffer wrote: > > > On Fri, Jun 19, 2020 at 1:40 PM Max Reitz wrote: > > >> > > >> Hi, > > >> > > >> As discussed here: > > >> > > >> https://lists.nongnu.org/arch

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-23 Thread Kevin Wolf
Am 23.06.2020 um 09:28 hat Max Reitz geschrieben: > On 22.06.20 19:44, Alberto Garcia wrote: > > On Mon 22 Jun 2020 11:47:32 AM CEST, Max Reitz wrote: > >>> I don't know the internals of qcow2 data_file, but are we really using > >>> qcow2 metadata when accessing the data file? > >> > >> Yes. > >>

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-23 Thread Max Reitz
On 22.06.20 19:44, Alberto Garcia wrote: > On Mon 22 Jun 2020 11:47:32 AM CEST, Max Reitz wrote: >>> I don't know the internals of qcow2 data_file, but are we really using >>> qcow2 metadata when accessing the data file? >> >> Yes. >> >>> This may have unwanted performance consequences. >> >> I don

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-22 Thread Alberto Garcia
On Mon 22 Jun 2020 11:47:32 AM CEST, Max Reitz wrote: >> I don't know the internals of qcow2 data_file, but are we really using >> qcow2 metadata when accessing the data file? > > Yes. > >> This may have unwanted performance consequences. > > I don’t think so, because in practice normal lookups of

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-22 Thread Nir Soffer
On Mon, Jun 22, 2020 at 12:47 PM Max Reitz wrote: > > On 22.06.20 00:25, Nir Soffer wrote: > > On Fri, Jun 19, 2020 at 1:40 PM Max Reitz wrote: > >> > >> Hi, > >> > >> As discussed here: > >> > >> https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html > >> https://lists.nongnu.org

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-22 Thread Max Reitz
On 22.06.20 00:25, Nir Soffer wrote: > On Fri, Jun 19, 2020 at 1:40 PM Max Reitz wrote: >> >> Hi, >> >> As discussed here: >> >> https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html >> https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00329.html >> https://lists.nongnu.

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-21 Thread Nir Soffer
On Fri, Jun 19, 2020 at 1:40 PM Max Reitz wrote: > > Hi, > > As discussed here: > > https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html > https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00329.html > https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00240.ht

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200619104012.235977-1-mre...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash expor

[PATCH 0/2] qcow2: Force preallocation with data-file-raw

2020-06-19 Thread Max Reitz
Hi, As discussed here: https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00329.html https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00240.html I think that qcow2 images with data-file-raw should always h