Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-05-06 Thread Paolo Bonzini
On Thu, Apr 25, 2024 at 8:43 PM Thomas Huth wrote: > OTOH, it seems > to work fine, and the FDC is only disabled when it is not available > in the binary, so I hope this patch is fine, too. We do the same for parallel so i think it should be fine---definitely for -nodefaults, and I'd say in gener

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-05-06 Thread Philippe Mathieu-Daudé
On 25/4/24 20:43, Thomas Huth wrote: Thomas Huth (3): hw/i386/pc: Allow to compile without CONFIG_FDC_ISA hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA hw/i386: Add the possibility to use i440fx and isapc without FDC Series: Acked-by: Philippe Mathieu-Daudé

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-29 Thread Kevin Wolf
[ Cc: qemu-block ] Am 25.04.2024 um 20:43 hat Thomas Huth geschrieben: > For downstream versions of QEMU, we'd like to be able to compile QEMU > without the FDC code included (since it's not required for modern VMs > anymore and the FDC code has rather a bad reputation, see the VENOM CVE). > > Th

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
On 25/04/2024 22.56, Philippe Mathieu-Daudé wrote: Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation, se

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Philippe Mathieu-Daudé
Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation, see the VENOM CVE). IIRC you still need to keep the

[PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation, see the VENOM CVE). The q35 machine can already be instantiated without FDC, but for being able to link