Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-22 Thread Peter Maydell
On Fri, 22 Mar 2024 at 14:08, Cédric Le Goater wrote: > > On 3/20/24 16:00, Peter Maydell wrote: > > On Wed, 20 Mar 2024 at 14:10, Mark Burton wrote: > >> I’d broaden this to all ’signals’ (IRQ, Reset etc) - and I guess > >> similar statements apply, with the “bridge” between the function > >>

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-22 Thread Cédric Le Goater
On 3/20/24 16:00, Peter Maydell wrote: On Wed, 20 Mar 2024 at 14:10, Mark Burton wrote: I’d broaden this to all ’signals’ (IRQ, Reset etc) - and I guess similar statements apply, with the “bridge” between the function and the GPIO mechanism moved closer or further from the originator(s) of the

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 16:00, Peter Maydell wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On Wed, 20 Mar 2024 at 14:10, Mark Burton wrote: >> I’d broaden this to all ’signals’ (IRQ, Reset etc) -

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 14:10, Mark Burton wrote: > I’d broaden this to all ’signals’ (IRQ, Reset etc) - and I guess > similar statements apply, with the “bridge” between the function > and the GPIO mechanism moved closer or further from the originator(s) > of the activity. > > The issue isn’t my

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 14:55, Peter Maydell wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On Wed, 20 Mar 2024 at 12:31, Mark Burton wrote: >>> On 20 Mar 2024, at 13:00, Peter Maydell wrote: >>>

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 12:31, Mark Burton wrote: > > On 20 Mar 2024, at 13:00, Peter Maydell wrote: > > What NMI probably ought to be is board-specific: so it's like > > having some notional front panel switch labeled "NMI", and the > > Do the youngsters of today know what one of those is ? >

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 13:00, Peter Maydell wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On Wed, 20 Mar 2024 at 11:20, Philippe Mathieu-Daudé > wrote: >> >> On 20/2/24 16:19, Thomas Huth

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 11:20, Philippe Mathieu-Daudé wrote: > > On 20/2/24 16:19, Thomas Huth wrote: > > On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: > >> Have s390x always deliver NMI to the first CPU, > >> remove the @cpu_index argument from handler, > >> rename API as nmi_trigger() (not

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 12:19, Philippe Mathieu-Daudé wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On 20/2/24 16:19, Thomas Huth wrote: >> On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: >>>

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Philippe Mathieu-Daudé
On 20/2/24 16:19, Thomas Huth wrote: On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Could you please add some rationale here why this is needed

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-02-20 Thread Philippe Mathieu-Daudé
On 20/2/24 16:19, Thomas Huth wrote: On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Could you please add some rationale here why this is needed

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-02-20 Thread Thomas Huth
On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Could you please add some rationale here why this is needed / desired? Thanks, Thomas

[PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-02-20 Thread Philippe Mathieu-Daudé
Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Philippe Mathieu-Daudé (4): hw/nmi: Use object_child_foreach_recursive() in nmi_children() hw/s390x/virtio-ccw: Always deliver NMI to first CPU