Re: [PATCH 0/5] hw/timer/i8254: Un-inline and simplify IRQs

2023-03-01 Thread Michael S. Tsirkin
On Wed, Feb 15, 2023 at 06:43:48PM +0100, Philippe Mathieu-Daudé wrote: > i8254_pit_init() uses a odd pattern of "use this IRQ output > line if non-NULL, otherwise use the ISA IRQ #number as output". > > Rework as simply "Use this IRQ output". Acked-by: Michael S. Tsirkin Given it also affect

[PATCH 0/5] hw/timer/i8254: Un-inline and simplify IRQs

2023-02-15 Thread Philippe Mathieu-Daudé
i8254_pit_init() uses a odd pattern of "use this IRQ output line if non-NULL, otherwise use the ISA IRQ #number as output". Rework as simply "Use this IRQ output". Un-inline/rename/document functions. Based-on: <20230215161641.32663-1-phi...@linaro.org> "hw/ide: Untangle ISA/PCI abuses