Re: [PATCH 0/8] hw/ppc: Convert UIC device to QOM

2020-12-14 Thread Peter Maydell
On Mon, 14 Dec 2020 at 09:01, David Gibson wrote: > > On Sat, Dec 12, 2020 at 12:15:29AM +, Peter Maydell wrote: > > This patchseries converts the PPC UIC "Universal Interrupt > > Controller" to a QOM device. My main reason for doing it is that > > this fixes a couple of long-standing

Re: [PATCH 0/8] hw/ppc: Convert UIC device to QOM

2020-12-14 Thread David Gibson
On Sat, Dec 12, 2020 at 12:15:29AM +, Peter Maydell wrote: > This patchseries converts the PPC UIC "Universal Interrupt > Controller" to a QOM device. My main reason for doing it is that > this fixes a couple of long-standing trivial Coverity issues -- the > current ppcuic_init() function

Re: [PATCH 0/8] hw/ppc: Convert UIC device to QOM

2020-12-12 Thread BALATON Zoltan via
On Sat, 12 Dec 2020, Peter Maydell wrote: This patchseries converts the PPC UIC "Universal Interrupt Controller" to a QOM device. My main reason for doing it is that Thanks for doing this clean up. this fixes a couple of long-standing trivial Coverity issues -- the current ppcuic_init()

Re: [PATCH 0/8] hw/ppc: Convert UIC device to QOM

2020-12-12 Thread Peter Maydell
On Sat, 12 Dec 2020 at 17:43, BALATON Zoltan wrote: > Interestingly the firmware does not use irqs at all, it just polls for > them it seems. AROS and AmigaOS does seem to break though. With AROS I get > this exception after your series but it's not very helpful: > AmigaOS also fails to boot but

[PATCH 0/8] hw/ppc: Convert UIC device to QOM

2020-12-11 Thread Peter Maydell
This patchseries converts the PPC UIC "Universal Interrupt Controller" to a QOM device. My main reason for doing it is that this fixes a couple of long-standing trivial Coverity issues -- the current ppcuic_init() function allocates an array of qemu_irqs which the callers then leak. (The leak is