Re: [PATCH 00/14] rust: example of bindings code for Rust in QEMU

2024-07-05 Thread Paolo Bonzini
Hi, first of all I want to clarify the raison d'etre for this posting, which I have also explained to Manos. Nothing you see here is code that will be certainly included in QEMU; it's (mostly) throwaway by design. I don't have much attachment to any of the code except perhaps the casting and refere

Re: [PATCH 00/14] rust: example of bindings code for Rust in QEMU

2024-07-05 Thread Pierrick Bouvier
On 7/5/24 01:06, Paolo Bonzini wrote: On Thu, Jul 4, 2024 at 9:26 PM Pierrick Bouvier wrote: Patches 9-10 deal with how to define new subclasses in Rust. They are a lot less polished and less ready. There is probably a lot of polish that could be applied to make the code look nicer, but I gue

Re: [PATCH 00/14] rust: example of bindings code for Rust in QEMU

2024-07-05 Thread Paolo Bonzini
On Thu, Jul 4, 2024 at 9:26 PM Pierrick Bouvier wrote: > > Patches 9-10 deal with how to define new subclasses in Rust. They are > > a lot less polished and less ready. There is probably a lot of polish > > that could be applied to make the code look nicer, but I guess there is > > always time t

Re: [PATCH 00/14] rust: example of bindings code for Rust in QEMU

2024-07-04 Thread Pierrick Bouvier
Hi Paolo, thanks for this series! Some comments below. On 7/1/24 07:58, Paolo Bonzini wrote: Hi all, this is an example of what some bindings code for QEMU would look like. Note that some parts of this code are barely expected to compile, and are probably full of bugs, but still should look li

[PATCH 00/14] rust: example of bindings code for Rust in QEMU

2024-07-01 Thread Paolo Bonzini
Hi all, this is an example of what some bindings code for QEMU would look like. Note that some parts of this code are barely expected to compile, and are probably full of bugs, but still should look like finished code (in fact, because they compile, the type system parts should be okay; though a c