From: Zhao Liu <zhao1....@intel.com> Hi list,
This series is the follow-up of my previous @errp related patch set [1]. The @errp's second restriction (in qapi/error) said: * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepend() or * error_append_hint(), because that doesn't work with &error_fatal. * ERRP_GUARD() lifts these restrictions. With this requirement, there are many places where ERRP_GUARD() needs to be added, especially places where there is no way to ensure that the incoming @errp is pointing to @errp_fatal or not. To make review easier (and to make sure I'm doing the right thing), I just post the first part here. Welcome your feedback! [1]: https://lore.kernel.org/qemu-devel/20240223085653.1255438-1-zhao1....@linux.intel.com/ Thanks and Best Regards, Zhao --- Zhao Liu (16): error: Add error_vprepend() in comment of ERRP_GUARD() rules backends/iommufd: Fix missing ERRP_GUARD() for error_prepend() block: Fix missing ERRP_GUARD() for error_prepend() block/cbw: Fix missing ERRP_GUARD() for error_prepend() block/nbd: Fix missing ERRP_GUARD() for error_prepend() block/nvme: Fix missing ERRP_GUARD() for error_prepend() block/qcow2-bitmap: Fix missing ERRP_GUARD() for error_prepend() block/qcow2: Fix missing ERRP_GUARD() for error_prepend() block/qed: Fix missing ERRP_GUARD() for error_prepend() block/snapshot: Fix missing ERRP_GUARD() for error_prepend() block/vdi: Fix missing ERRP_GUARD() for error_prepend() block/vmdk: Fix missing ERRP_GUARD() for error_prepend() block/virtio-blk: Fix missing ERRP_GUARD() for error_prepend() hw/char/xen_console: Fix missing ERRP_GUARD() for error_prepend() hw/core/loader-fit: Fix missing ERRP_GUARD() for error_prepend() hw/core/qdev-properties-system: Fix missing ERRP_GUARD() for error_prepend() backends/iommufd.c | 1 + block.c | 4 ++++ block/copy-before-write.c | 1 + block/nbd.c | 1 + block/nvme.c | 3 +++ block/qcow2-bitmap.c | 1 + block/qcow2.c | 2 ++ block/qed.c | 1 + block/snapshot.c | 2 ++ block/vdi.c | 1 + block/vmdk.c | 1 + hw/block/virtio-blk.c | 1 + hw/char/xen_console.c | 1 + hw/core/loader-fit.c | 2 ++ hw/core/qdev-properties-system.c | 1 + include/qapi/error.h | 2 +- 16 files changed, 24 insertions(+), 1 deletion(-) -- 2.34.1
