Re: [PATCH 01/13] target/arm: Add _aa32_ to isar_feature functions testing 32-bit ID registers

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 6:37 PM, Peter Maydell wrote: Enforce a convention that an isar_feature function that tests a 32-bit ID register always has _aa32_ in its name, and one that tests a 64-bit ID register always has _aa64_ in its name. We already follow this except for three cases: thumb_div, arm_div and j

Re: [PATCH 01/13] target/arm: Add _aa32_ to isar_feature functions testing 32-bit ID registers

2020-02-11 Thread Richard Henderson
On 2/11/20 9:37 AM, Peter Maydell wrote: > Enforce a convention that an isar_feature function that tests a > 32-bit ID register always has _aa32_ in its name, and one that > tests a 64-bit ID register always has _aa64_ in its name. > We already follow this except for three cases: thumb_div, > arm_d

[PATCH 01/13] target/arm: Add _aa32_ to isar_feature functions testing 32-bit ID registers

2020-02-11 Thread Peter Maydell
Enforce a convention that an isar_feature function that tests a 32-bit ID register always has _aa32_ in its name, and one that tests a 64-bit ID register always has _aa64_ in its name. We already follow this except for three cases: thumb_div, arm_div and jazelle, which all need _aa32_ adding. (As