Re: [PATCH 01/14] block: return status from bdrv_append and friends

2020-09-17 Thread Alberto Garcia
On Wed 09 Sep 2020 08:59:17 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in

Re: [PATCH 01/14] block: return status from bdrv_append and friends

2020-09-10 Thread Greg Kurz
On Wed, 9 Sep 2020 21:59:17 +0300 Vladimir Sementsov-Ogievskiy wrote: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in

[PATCH 01/14] block: return status from bdrv_append and friends

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together with setting errp and avoid void functions with errp parameter. Let's improve bdrv_append and some friends to reduce error-propagation overhead in further patches. Choose int return status, because bdrv_replace_node() has call