Re: [PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize()

2020-08-13 Thread David Gibson
On Thu, Aug 13, 2020 at 11:39:27PM +0200, Greg Kurz wrote: > On Thu, 13 Aug 2020 16:57:04 -0300 > Daniel Henrique Barboza wrote: > > > Greg, > > > > This patch is breaking guest startup in ppc-for-5.2 for me. The process > > gives an almost instant segfault. Here's what I'm doing: > > > > Ok,

Re: [PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize()

2020-08-13 Thread Greg Kurz
On Thu, 13 Aug 2020 16:57:04 -0300 Daniel Henrique Barboza wrote: > Greg, > > This patch is breaking guest startup in ppc-for-5.2 for me. The process > gives an almost instant segfault. Here's what I'm doing: > Ok, this is because this patch should have been applied after the "spapr: Cleanups

Re: [PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize()

2020-08-13 Thread Daniel Henrique Barboza
Greg, This patch is breaking guest startup in ppc-for-5.2 for me. The process gives an almost instant segfault. Here's what I'm doing: $ sudo ./qemu-system-ppc64 -machine pseries-5.1,accel=kvm,usb=off,dump-guest-core=off -m 65536\ -overcommit mem-lock=off -smp 4,sockets=4,cores=1,threads=1 -rtc

Re: [PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize()

2020-08-13 Thread David Gibson
On Mon, Aug 10, 2020 at 06:53:58PM +0200, Greg Kurz wrote: > The spapr_phb_realize() function has a local_err variable which > is used to: > > 1) check failures of spapr_irq_findone() and spapr_irq_claim() > > 2) prepend extra information to the error message > > Recent work from Markus Armbrust

[PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize()

2020-08-10 Thread Greg Kurz
The spapr_phb_realize() function has a local_err variable which is used to: 1) check failures of spapr_irq_findone() and spapr_irq_claim() 2) prepend extra information to the error message Recent work from Markus Armbruster highlighted we get better code when testing the return value of a functi