Re: [PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled

2020-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2020 at 04:02:43PM +0200, Philippe Mathieu-Daudé wrote: > On 6/26/20 12:36 PM, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2020 at 08:48:22PM +0200, Philippe Mathieu-Daudé wrote: > >> Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is > >> not enabled. > > > > Why? > > >

Re: [PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 12:36 PM, Stefan Hajnoczi wrote: > On Thu, Jun 25, 2020 at 08:48:22PM +0200, Philippe Mathieu-Daudé wrote: >> Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is >> not enabled. > > Why? > > This saves 8 trace events, each with 8 arguments. I guess the intent is > to improve

Re: [PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:22PM +0200, Philippe Mathieu-Daudé wrote: > Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is > not enabled. Why? This saves 8 trace events, each with 8 arguments. I guess the intent is to improve performance. Did you measure an improvement? signature.as

[PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled

2020-06-25 Thread Philippe Mathieu-Daudé
Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is not enabled. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index eb2f54dd9d..1e5b40f61c 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -367,6