Re: [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 3:58 PM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xilinx_zynq.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/xilinx_zynq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

[PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions

2019-10-20 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xilinx_zynq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index c14774e542..3a0fa5b23f 100644 ---