Re: [PATCH 02/13] target/arm: Add isar_feature_any_fp16 and document naming/usage conventions

2020-02-12 Thread Peter Maydell
On Wed, 12 Feb 2020 at 06:24, Philippe Mathieu-Daudé wrote: > > On 2/11/20 6:37 PM, Peter Maydell wrote: > > @@ -185,7 +185,7 @@ uint32_t vfp_get_fpscr(CPUARMState *env) > > void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) > > { > > /* When ARMv8.2-FP16 is not supported, FZ16 i

Re: [PATCH 02/13] target/arm: Add isar_feature_any_fp16 and document naming/usage conventions

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 6:37 PM, Peter Maydell wrote: Our current usage of the isar_feature feature tests almost always uses an _aa32_ test when the code path is known to be AArch32 specific and an _aa64_ test when the code path is known to be AArch64 specific. There is just one exception: in the vfp_set_fpsc

Re: [PATCH 02/13] target/arm: Add isar_feature_any_fp16 and document naming/usage conventions

2020-02-11 Thread Richard Henderson
On 2/11/20 9:37 AM, Peter Maydell wrote: > Our current usage of the isar_feature feature tests almost always > uses an _aa32_ test when the code path is known to be AArch32 > specific and an _aa64_ test when the code path is known to be > AArch64 specific. There is just one exception: in the vfp_se

[PATCH 02/13] target/arm: Add isar_feature_any_fp16 and document naming/usage conventions

2020-02-11 Thread Peter Maydell
Our current usage of the isar_feature feature tests almost always uses an _aa32_ test when the code path is known to be AArch32 specific and an _aa64_ test when the code path is known to be AArch64 specific. There is just one exception: in the vfp_set_fpscr helper we check aa64_fp16 to determine wh