Re: [PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-19 Thread Vladimir Sementsov-Ogievskiy
19.07.2021 15:58, Vladimir Sementsov-Ogievskiy wrote: Could also be done with something like imgopts = os.environ.get('IMGOPTS') imgopts is a string after it. So you don't need to join it? opts = optstr2dict(','.join(([imgopts] if imgopts else []) + parsed.o)) Build a string to be than

Re: [PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-19 Thread Vladimir Sementsov-Ogievskiy
16.07.2021 13:34, Vladimir Sementsov-Ogievskiy wrote: 16.07.2021 13:07, Max Reitz wrote: On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote: Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want

Re: [PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2021 13:07, Max Reitz wrote: On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote: Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around

Re: [PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-16 Thread Max Reitz
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote: Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in

[PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in IMGOPTS, if test want qcow2 in compatibility mode. As