Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread Bernhard Beschow
Am 13. Juni 2023 15:01:40 UTC schrieb "Michael S. Tsirkin" : >On Tue, Jun 13, 2023 at 03:40:28PM +0200, Philippe Mathieu-Daudé wrote: >> On 13/6/23 15:05, Igor Mammedov wrote: >> > On Tue, 13 Jun 2023 13:07:17 +0200 (CEST) >> > BALATON Zoltan wrote: >> > >> > > On Tue, 13 Jun 2023, Michael S.

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 03:40:28PM +0200, Philippe Mathieu-Daudé wrote: > On 13/6/23 15:05, Igor Mammedov wrote: > > On Tue, 13 Jun 2023 13:07:17 +0200 (CEST) > > BALATON Zoltan wrote: > > > > > On Tue, 13 Jun 2023, Michael S. Tsirkin wrote: > > > > On Tue, Jun 13, 2023 at 09:46:53AM +0200, Bernh

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread Philippe Mathieu-Daudé
On 13/6/23 15:05, Igor Mammedov wrote: On Tue, 13 Jun 2023 13:07:17 +0200 (CEST) BALATON Zoltan wrote: On Tue, 13 Jun 2023, Michael S. Tsirkin wrote: On Tue, Jun 13, 2023 at 09:46:53AM +0200, Bernhard Beschow wrote: On Mon, Jun 12, 2023 at 3:01 PM Igor Mammedov wrote: On Sun, 11 Jun 2

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread Igor Mammedov
On Tue, 13 Jun 2023 13:07:17 +0200 (CEST) BALATON Zoltan wrote: > On Tue, 13 Jun 2023, Michael S. Tsirkin wrote: > > On Tue, Jun 13, 2023 at 09:46:53AM +0200, Bernhard Beschow wrote: > >> On Mon, Jun 12, 2023 at 3:01 PM Igor Mammedov wrote: > >> > >> On Sun, 11 Jun 2023 12:33:59 +0200 > >>

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread BALATON Zoltan
On Tue, 13 Jun 2023, Michael S. Tsirkin wrote: On Tue, Jun 13, 2023 at 09:46:53AM +0200, Bernhard Beschow wrote: On Mon, Jun 12, 2023 at 3:01 PM Igor Mammedov wrote: On Sun, 11 Jun 2023 12:33:59 +0200 Bernhard Beschow wrote: > Fixes the following clangd warning (-Winitializer-over

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 09:46:53AM +0200, Bernhard Beschow wrote: > On Mon, Jun 12, 2023 at 3:01 PM Igor Mammedov wrote: > > On Sun, 11 Jun 2023 12:33:59 +0200 > Bernhard Beschow wrote: > > > Fixes the following clangd warning (-Winitializer-overrides): > > > >   q35.c:297:1

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-13 Thread Bernhard Beschow
On Mon, Jun 12, 2023 at 3:01 PM Igor Mammedov wrote: > On Sun, 11 Jun 2023 12:33:59 +0200 > Bernhard Beschow wrote: > > > Fixes the following clangd warning (-Winitializer-overrides): > > > > q35.c:297:19: Initializer overrides prior initialization of this > subobject > > q35.c:292:19: previ

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-12 Thread Igor Mammedov
On Sun, 11 Jun 2023 12:33:59 +0200 Bernhard Beschow wrote: > Fixes the following clangd warning (-Winitializer-overrides): > > q35.c:297:19: Initializer overrides prior initialization of this subobject > q35.c:292:19: previous initialization is here > > Settle on native endian which causes

[PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-06-11 Thread Bernhard Beschow
Fixes the following clangd warning (-Winitializer-overrides): q35.c:297:19: Initializer overrides prior initialization of this subobject q35.c:292:19: previous initialization is here Settle on native endian which causes the least overhead. Fixes: bafc90bdc594 ("q35: implement TSEG") Signed-o