Re: [PATCH 02/17] acpi: x86: deduplicate HPET AML building

2022-07-07 Thread Igor Mammedov
On Thu, 7 Jul 2022 06:08:35 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 07, 2022 at 11:16:16AM +0200, Igor Mammedov wrote: > > On Fri, 1 Jul 2022 12:26:16 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jul 01, 2022 at 09:35:00AM -0400, Igor Mammedov wrote: > > > > HPET AML does

Re: [PATCH 02/17] acpi: x86: deduplicate HPET AML building

2022-07-07 Thread Michael S. Tsirkin
On Thu, Jul 07, 2022 at 11:16:16AM +0200, Igor Mammedov wrote: > On Fri, 1 Jul 2022 12:26:16 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Jul 01, 2022 at 09:35:00AM -0400, Igor Mammedov wrote: > > > HPET AML doesn't depend on piix4 nor q35, move code buiding it > > > to common scope to avoid

Re: [PATCH 02/17] acpi: x86: deduplicate HPET AML building

2022-07-07 Thread Igor Mammedov
On Fri, 1 Jul 2022 12:26:16 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 01, 2022 at 09:35:00AM -0400, Igor Mammedov wrote: > > HPET AML doesn't depend on piix4 nor q35, move code buiding it > > to common scope to avoid duplication. > > > > Signed-off-by: Igor Mammedov > > Apropos, tests/

Re: [PATCH 02/17] acpi: x86: deduplicate HPET AML building

2022-07-01 Thread Michael S. Tsirkin
On Fri, Jul 01, 2022 at 09:35:00AM -0400, Igor Mammedov wrote: > HPET AML doesn't depend on piix4 nor q35, move code buiding it > to common scope to avoid duplication. > > Signed-off-by: Igor Mammedov Apropos, tests/data/acpi/rebuild-expected-aml.sh ignores the fact that some tables might be ide

[PATCH 02/17] acpi: x86: deduplicate HPET AML building

2022-07-01 Thread Igor Mammedov
HPET AML doesn't depend on piix4 nor q35, move code buiding it to common scope to avoid duplication. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index cad6f5ac41..