Re: [PATCH 02/21] net/virtio: Fix failover error handling crash bugs

2019-12-02 Thread Jens Freimann
On Sat, Nov 30, 2019 at 08:42:21PM +0100, Markus Armbruster wrote: Functions that take an Error ** parameter to pass an error to the caller expect the parameter to point to null. failover_replug_primary() violates this precondition in several places: * After qemu_opts_from_qdict() failed, *errp

[PATCH 02/21] net/virtio: Fix failover error handling crash bugs

2019-11-30 Thread Markus Armbruster
Functions that take an Error ** parameter to pass an error to the caller expect the parameter to point to null. failover_replug_primary() violates this precondition in several places: * After qemu_opts_from_qdict() failed, *errp is no longer null. Passing it to error_setg() is wrong, and will tr