Re: [PATCH 02/23] target/i386: fix gen_prepare_size_nz condition

2024-07-01 Thread Igor Mammedov
On Fri, 28 Jun 2024 15:34:58 +0100 Alex Bennée wrote: > Alex Bennée writes: > > > Incorrect brace positions causes an unintended overflow on 32 bit > > builds and shenanigans result. > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2413 > > Suggested-by: Mark Cave-Ayland > > Sig

Re: [PATCH 02/23] target/i386: fix gen_prepare_size_nz condition

2024-06-28 Thread Richard Henderson
On 6/28/24 10:54, Richard Henderson wrote: On 6/28/24 05:42, Alex Bennée wrote: Incorrect brace positions causes an unintended overflow on 32 bit builds and shenanigans result. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2413 Suggested-by: Mark Cave-Ayland Signed-off-by: Alex Benné

Re: [PATCH 02/23] target/i386: fix gen_prepare_size_nz condition

2024-06-28 Thread Richard Henderson
On 6/28/24 05:42, Alex Bennée wrote: Incorrect brace positions causes an unintended overflow on 32 bit builds and shenanigans result. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2413 Suggested-by: Mark Cave-Ayland Signed-off-by: Alex Bennée --- target/i386/tcg/translate.c | 2 +-

Re: [PATCH 02/23] target/i386: fix gen_prepare_size_nz condition

2024-06-28 Thread Alex Bennée
Alex Bennée writes: > Incorrect brace positions causes an unintended overflow on 32 bit > builds and shenanigans result. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2413 > Suggested-by: Mark Cave-Ayland > Signed-off-by: Alex Bennée This seems to trigger regressions in: qtest

[PATCH 02/23] target/i386: fix gen_prepare_size_nz condition

2024-06-28 Thread Alex Bennée
Incorrect brace positions causes an unintended overflow on 32 bit builds and shenanigans result. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2413 Suggested-by: Mark Cave-Ayland Signed-off-by: Alex Bennée --- target/i386/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 delet