Re: [PATCH 03/10] hw/riscv/sifive_u.c: simplify create_fdt()

2023-01-15 Thread Alistair Francis
On Thu, Jan 12, 2023 at 3:25 AM Daniel Henrique Barboza wrote: > > 'cmdline' isn't being used. Remove it. > > A MachineState pointer is being retrieved via a MACHINE() macro calling > qdev_get_machine(). Use MACHINE(s) instead to avoid calling qdev(). > > 'mem_size' is being set as machine->ram_s

[PATCH 03/10] hw/riscv/sifive_u.c: simplify create_fdt()

2023-01-11 Thread Daniel Henrique Barboza
'cmdline' isn't being used. Remove it. A MachineState pointer is being retrieved via a MACHINE() macro calling qdev_get_machine(). Use MACHINE(s) instead to avoid calling qdev(). 'mem_size' is being set as machine->ram_size by the caller. Retrieve it via ms->ram_size. Cc: Palmer Dabbelt Signed