Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

On 5/14/21 10:08 AM, Wainer dos Santos Moschetta wrote: Now it might throw a CalledProcessError given that `check=True`. Shouldn't it capture the exception and (possible) re-throw as an QEMUMachineError? I lied to you again. The existing callers all check for failure explicitly, so in the

Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

On 5/14/21 10:08 AM, Wainer dos Santos Moschetta wrote: Hi, On 5/12/21 6:46 PM, John Snow wrote: use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow ---   python/qemu/machine.py | 15 +--   1 file

Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

Hi, On 5/12/21 6:46 PM, John Snow wrote: use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow --- python/qemu/machine.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow --- python/qemu/machine.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py