Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-29 Thread Wainer dos Santos Moschetta
On 6/28/21 5:38 PM, John Snow wrote: On Mon, Jun 28, 2021 at 4:31 PM Wainer dos Santos Moschetta mailto:waine...@redhat.com>> wrote: On 6/25/21 12:45 PM, John Snow wrote: > tox is already testing the most recent versions. Let's use pipenv to > test the oldest versions we claim

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-28 Thread John Snow
On Mon, Jun 28, 2021 at 4:31 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote: > > On 6/25/21 12:45 PM, John Snow wrote: > > tox is already testing the most recent versions. Let's use pipenv to > > test the oldest versions we claim to support. This matches the stylistic > > choice to

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-28 Thread Wainer dos Santos Moschetta
On 6/25/21 12:45 PM, John Snow wrote: tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. Currently tox is testing with 3.6 too.

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > tox is already testing the most recent versions. Let's use pipenv to > test the oldest versions we claim to support. This matches the stylistic > choice to have pipenv always test our oldest supported Python version, 3.6. > > The effect of

[PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-25 Thread John Snow
tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. The effect of this is that the python-check-pipenv CI job on gitlab will now