Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-05-04 Thread Cornelia Huck
On Mon, 04 May 2020 17:24:59 +0200 Markus Armbruster wrote: > Cornelia Huck writes: > > > On Wed, 29 Apr 2020 07:51:04 +0200 > > Markus Armbruster wrote: > > > >> David Hildenbrand writes: > >> > >> > On 24.04.20 21:20, Markus Armbruster wrote: > >> >> Commit e47970f51d

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-05-04 Thread Markus Armbruster
Cornelia Huck writes: > On Wed, 29 Apr 2020 07:51:04 +0200 > Markus Armbruster wrote: > >> David Hildenbrand writes: >> >> > On 24.04.20 21:20, Markus Armbruster wrote: >> >> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API >> >> violations" neglected to change

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-05-04 Thread Cornelia Huck
On Wed, 29 Apr 2020 07:51:04 +0200 Markus Armbruster wrote: > David Hildenbrand writes: > > > On 24.04.20 21:20, Markus Armbruster wrote: > >> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API > >> violations" neglected to change visit_end_struct()'s Error ** argument > >>

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-04-28 Thread Markus Armbruster
David Hildenbrand writes: > On 24.04.20 21:20, Markus Armbruster wrote: >> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API >> violations" neglected to change visit_end_struct()'s Error ** argument >> along with the others. If visit_end_struct() failed, we'd take the > >

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-04-27 Thread David Hildenbrand
On 24.04.20 21:20, Markus Armbruster wrote: > Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API > violations" neglected to change visit_end_struct()'s Error ** argument > along with the others. If visit_end_struct() failed, we'd take the s/visit_end_struct/visit_check_struct/

[PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-04-24 Thread Markus Armbruster
Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API violations" neglected to change visit_end_struct()'s Error ** argument along with the others. If visit_end_struct() failed, we'd take the success path. Fortunately, it can't fail here: qobject_input_check_struct() checks we