Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Peter Xu
On Thu, Feb 01, 2024 at 10:30:19AM -0300, Fabiano Rosas wrote: > > @@ -586,7 +595,7 @@ void multifd_save_cleanup(void) > > if (!migrate_multifd()) { > > return; > > } > > -multifd_send_terminate_threads(NULL); > > +multifd_send_terminate_threads(); > > for (i = 0; i

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jan 31, 2024 at 12:05:08PM -0300, Fabiano Rosas wrote: >> pet...@redhat.com writes: >> >> > From: Peter Xu >> > >> > Multifd send side has two fields to indicate error quits: >> > >> > - MultiFDSendParams.quit >> > - _send_state->exiting >> > >> > Merge them into

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 12:05:08PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > Multifd send side has two fields to indicate error quits: > > > > - MultiFDSendParams.quit > > - _send_state->exiting > > > > Merge them into the global one. The

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-01-31 Thread Fabiano Rosas
pet...@redhat.com writes: > From: Peter Xu > > Multifd send side has two fields to indicate error quits: > > - MultiFDSendParams.quit > - _send_state->exiting > > Merge them into the global one. The replacement is done by changing all > p->quit checks into the global var check. The global

[PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-01-31 Thread peterx
From: Peter Xu Multifd send side has two fields to indicate error quits: - MultiFDSendParams.quit - _send_state->exiting Merge them into the global one. The replacement is done by changing all p->quit checks into the global var check. The global check doesn't need any lock. A few more