Re: [PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in board code

2023-06-12 Thread Igor Mammedov
On Sun, 11 Jun 2023 12:34:00 +0200 Bernhard Beschow wrote: > The Q35 PCI host currently sets the PC machine's PCI bus attribute > through global state, thereby assuming the machine to be a PC machine. > The Q35 machine code already holds on to Q35's pci bus attribute, so can > easily set its own

Re: [PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in board code

2023-06-12 Thread Philippe Mathieu-Daudé
On 11/6/23 12:34, Bernhard Beschow wrote: The Q35 PCI host currently sets the PC machine's PCI bus attribute through global state, thereby assuming the machine to be a PC machine. The Q35 machine code already holds on to Q35's pci bus attribute, so can easily set its own property while preserving

[PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in board code

2023-06-11 Thread Bernhard Beschow
The Q35 PCI host currently sets the PC machine's PCI bus attribute through global state, thereby assuming the machine to be a PC machine. The Q35 machine code already holds on to Q35's pci bus attribute, so can easily set its own property while preserving encapsulation. Signed-off-by: Bernhard Bes