Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types

2020-09-24 Thread John Snow
On 9/23/20 3:42 PM, Eduardo Habkost wrote: On Tue, Sep 22, 2020 at 05:13:00PM -0400, John Snow wrote: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow --- scripts/qapi/expr.py | 25

Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types

2020-09-24 Thread John Snow
On 9/24/20 8:05 PM, Cleber Rosa wrote: On Wed, Sep 23, 2020 at 03:42:24PM -0400, Eduardo Habkost wrote: On Tue, Sep 22, 2020 at 05:13:00PM -0400, John Snow wrote: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the

Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:13:00PM -0400, John Snow wrote: > mypy does not know the types of values stored in Dicts that masquerade > as objects. Help the type checker out by constraining the type. > > Signed-off-by: John Snow Reviewed-by: Cleber Rosa signature.asc Description: PGP signature

Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types

2020-09-24 Thread Cleber Rosa
On Wed, Sep 23, 2020 at 03:42:24PM -0400, Eduardo Habkost wrote: > On Tue, Sep 22, 2020 at 05:13:00PM -0400, John Snow wrote: > > mypy does not know the types of values stored in Dicts that masquerade > > as objects. Help the type checker out by constraining the type. > > > > Signed-off-by: John

Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:13:00PM -0400, John Snow wrote: > mypy does not know the types of values stored in Dicts that masquerade > as objects. Help the type checker out by constraining the type. > > Signed-off-by: John Snow > --- > scripts/qapi/expr.py | 25 ++--- > 1

[PATCH 03/16] qapi/expr.py: constrain incoming expression types

2020-09-22 Thread John Snow
mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow --- scripts/qapi/expr.py | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git