Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-05-04 Thread Kevin Wolf
Am 27.04.2023 um 22:49 hat Paolo Bonzini geschrieben: > Il gio 27 apr 2023, 19:00 Kevin Wolf ha scritto: > > > By the way, and slightly unrelated, can vrc somehow help with finding > > places that call coroutine wrappers without holding the AioContext lock? > > (This results in an abort() when AI

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-05-01 Thread Stefan Hajnoczi
On Tue, Apr 25, 2023 at 07:31:41PM +0200, Kevin Wolf wrote: > These functions must not be called in coroutine context, because they > need write access to the graph. > > Signed-off-by: Kevin Wolf > --- > include/block/block-global-state.h | 3 ++- > include/sysemu/block-backend-global-

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-04-27 Thread Paolo Bonzini
Il gio 27 apr 2023, 19:00 Kevin Wolf ha scritto: > By the way, and slightly unrelated, can vrc somehow help with finding > places that call coroutine wrappers without holding the AioContext lock? > (This results in an abort() when AIO_WAIT_WHILE() tries to unlock the > AioContext.) This is one of

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-04-27 Thread Kevin Wolf
Am 27.04.2023 um 16:30 hat Paolo Bonzini geschrieben: > Il mar 25 apr 2023, 19:32 Kevin Wolf ha scritto: > > > These functions must not be called in coroutine context, because they > > need write access to the graph. > > > > With these patches applied vrc is still complaining about calls to > bd

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-04-27 Thread Paolo Bonzini
Il mar 25 apr 2023, 19:32 Kevin Wolf ha scritto: > These functions must not be called in coroutine context, because they > need write access to the graph. > With these patches applied vrc is still complaining about calls to bdrv_unref_child from qcow2_do_open and qcow2_do_close. Otherwise, the

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-04-25 Thread Eric Blake
On Tue, Apr 25, 2023 at 07:31:41PM +0200, Kevin Wolf wrote: > These functions must not be called in coroutine context, because they > need write access to the graph. > > Signed-off-by: Kevin Wolf > --- > include/block/block-global-state.h | 3 ++- > include/sysemu/block-backend-global-

[PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-04-25 Thread Kevin Wolf
These functions must not be called in coroutine context, because they need write access to the graph. Signed-off-by: Kevin Wolf --- include/block/block-global-state.h | 3 ++- include/sysemu/block-backend-global-state.h | 5 - block.c | 2 +- b