Re: [PATCH 03/21] preallocate: Don't poll during permission updates

2023-08-22 Thread Stefan Hajnoczi
On Thu, Aug 17, 2023 at 02:50:02PM +0200, Kevin Wolf wrote: > When the permission related BlockDriver callbacks are called, we are in > the middle of an operation traversing the block graph. Polling in such a > place is a very bad idea because the graph could change in unexpected > ways. In the

Re: [PATCH 03/21] preallocate: Don't poll during permission updates

2023-08-18 Thread Eric Blake
On Thu, Aug 17, 2023 at 02:50:02PM +0200, Kevin Wolf wrote: > When the permission related BlockDriver callbacks are called, we are in > the middle of an operation traversing the block graph. Polling in such a > place is a very bad idea because the graph could change in unexpected > ways. In the

[PATCH 03/21] preallocate: Don't poll during permission updates

2023-08-17 Thread Kevin Wolf
When the permission related BlockDriver callbacks are called, we are in the middle of an operation traversing the block graph. Polling in such a place is a very bad idea because the graph could change in unexpected ways. In the future, callers will also hold the graph lock, which is likely to turn