Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros

2023-08-08 Thread Richard Henderson
On 8/8/23 19:41, Warner Losh wrote: I tried to implement both get and put in terms of this, but found that it broke the blitz branch. So why don't we land this as is for bsd-user and then one of us can try to put it into common-user so as to not create too many waves for our GSoC student

Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 7:47 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/8/23 18:39, Warner Losh wrote: > > > +#define __put_user_e(x, hptr, e) > \ > > > +do { > \ > > > +PRAGMA_DISABLE_PACKED_WARNING; > \ > >

Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros

2023-08-08 Thread Richard Henderson
On 8/8/23 18:39, Warner Losh wrote: > +#define __put_user_e(x, hptr, e)                                            \ > +    do {                                                                    \ > +        PRAGMA_DISABLE_PACKED_WARNING;                                      \

Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 3:03 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/23 23:07, Karim Taha wrote: > > From: Warner Losh > > > > Use __builtin_choose_expr to avoid type promotion from ?: > > in __put_user_e and __get_user_e macros. > > Copied from linux-user/qemu.h,

Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros

2023-08-08 Thread Richard Henderson
On 8/7/23 23:07, Karim Taha wrote: From: Warner Losh Use __builtin_choose_expr to avoid type promotion from ?: in __put_user_e and __get_user_e macros. Copied from linux-user/qemu.h, originally by Blue Swirl. Signed-off-by: Warner Losh Signed-off-by: Karim Taha --- bsd-user/qemu.h | 81

[PATCH 03/33] Update the definitions of __put_user and __get_user macros

2023-08-08 Thread Karim Taha
From: Warner Losh Use __builtin_choose_expr to avoid type promotion from ?: in __put_user_e and __get_user_e macros. Copied from linux-user/qemu.h, originally by Blue Swirl. Signed-off-by: Warner Losh Signed-off-by: Karim Taha --- bsd-user/qemu.h | 81