Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Jan 06, 2020 at 07:08:43PM +, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David A

Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-07 Thread Daniel P . Berrangé
On Mon, Jan 06, 2020 at 07:08:43PM +, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: Vivek Goyal

Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-06 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: Vivek Goyal > > > > > > We need to create files in the caller's context. Otherwise after > >

Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-06 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git) wrote: > > From: Vivek Goyal > > > > We need to create files in the caller's context. Otherwise after > > creating a file, the caller might not be able to do file operations

Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-06 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git) wrote: > From: Vivek Goyal > > We need to create files in the caller's context. Otherwise after > creating a file, the caller might not be able to do file operations on > that file. > > Changed effective uid/gid to caller's u

[PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2019-12-12 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal We need to create files in the caller's context. Otherwise after creating a file, the caller might not be able to do file operations on that file. Changed effective uid/gid to caller's uid/gid, create file and then switch back to uid/gid 0. Use syscall(setresuid, ...) otherwis