Re: [PATCH 04/11] target/i386: cleanup PAUSE helpers

2024-06-04 Thread Paolo Bonzini
On Tue, Jun 4, 2024 at 12:59 PM Richard Henderson wrote: > > On 6/4/24 02:18, Paolo Bonzini wrote: > > Use decode.c's support for intercepts, doing the check in TCG-generated > > code rather than the helper. This is cleaner because it allows removing > > the eip_addend argument to helper_pause(),

Re: [PATCH 04/11] target/i386: cleanup PAUSE helpers

2024-06-04 Thread Richard Henderson
On 6/4/24 02:18, Paolo Bonzini wrote: Use decode.c's support for intercepts, doing the check in TCG-generated code rather than the helper. This is cleaner because it allows removing the eip_addend argument to helper_pause(), even though it adds a bit of bloat for opcode 0x90's new decoding funct

[PATCH 04/11] target/i386: cleanup PAUSE helpers

2024-06-04 Thread Paolo Bonzini
Use decode.c's support for intercepts, doing the check in TCG-generated code rather than the helper. This is cleaner because it allows removing the eip_addend argument to helper_pause(), even though it adds a bit of bloat for opcode 0x90's new decoding function. Signed-off-by: Paolo Bonzini ---