Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-17 Thread Markus Armbruster
Daniel P. Berrangé writes: > So basically the code would always have access to all features, and > we would have no notion of "special" features any more. "Special" gets reduced to "predefined / known to the generator". > I'm happy to give that a try. Thank you!

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-17 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 08:08:42PM +0200, Markus Armbruster wrote: > Sorry for the delay; too many distractions, and I needed a good think. > > Daniel P. Berrangé writes: > > > On Fri, Jul 12, 2024 at 10:50:54AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Fri

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-16 Thread Markus Armbruster
Sorry for the delay; too many distractions, and I needed a good think. Daniel P. Berrangé writes: > On Fri, Jul 12, 2024 at 10:50:54AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Jul 12, 2024 at 10:07:34AM +0200, Markus Armbruster wrote: >> >> Daniel P. Berran

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 10:50:54AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Jul 12, 2024 at 10:07:34AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > The 'command-features' pragma allows for defining additional > >> > special featur

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-12 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Jul 12, 2024 at 10:07:34AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > The 'command-features' pragma allows for defining additional >> > special features that are unique to a particular QAPI schema >> > instance and its implementati

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 10:07:34AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The 'command-features' pragma allows for defining additional > > special features that are unique to a particular QAPI schema > > instance and its implementation. > > So far, we have special fea

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-12 Thread Markus Armbruster
Daniel P. Berrangé writes: > The 'command-features' pragma allows for defining additional > special features that are unique to a particular QAPI schema > instance and its implementation. So far, we have special features (predefined, known to the generator and treated specially), and normal feat

[PATCH 04/14] qapi: add a 'command-features' pragma

2024-06-04 Thread Daniel P . Berrangé
The 'command-features' pragma allows for defining additional special features that are unique to a particular QAPI schema instance and its implementation. Signed-off-by: Daniel P. Berrangé --- scripts/qapi/parser.py | 2 ++ scripts/qapi/source.py | 2 ++ 2 files changed, 4 insertions(+) diff --