Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-02-08 Thread Avihai Horon
On 06/02/2024 12:25, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, Jan 30, 2024 at 08:44:19PM +0200, Avihai Horon wrote: On 30/01/2024 7:57, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Jan 29, 2024 at 02:20:35PM +0200

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-02-06 Thread Peter Xu
On Tue, Jan 30, 2024 at 08:44:19PM +0200, Avihai Horon wrote: > > On 30/01/2024 7:57, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Mon, Jan 29, 2024 at 02:20:35PM +0200, Avihai Horon wrote: > > > On 29/01/2024 6:17, Peter Xu wrote: > > > > External

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-30 Thread Avihai Horon
On 30/01/2024 7:57, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Jan 29, 2024 at 02:20:35PM +0200, Avihai Horon wrote: On 29/01/2024 6:17, Peter Xu wrote: External email: Use caution opening links or attachments On Sun, Jan 28, 2024 at 05:43:52PM +0200,

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-29 Thread Peter Xu
On Mon, Jan 29, 2024 at 02:20:35PM +0200, Avihai Horon wrote: > > On 29/01/2024 6:17, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Sun, Jan 28, 2024 at 05:43:52PM +0200, Avihai Horon wrote: > > > On 25/01/2024 22:57, Fabiano Rosas wrote: > > > > Ext

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-29 Thread Fabiano Rosas
Peter Xu writes: > On Sun, Jan 28, 2024 at 05:43:52PM +0200, Avihai Horon wrote: >> >> On 25/01/2024 22:57, Fabiano Rosas wrote: >> > External email: Use caution opening links or attachments >> > >> > >> > Avihai Horon writes: >> > >> > > The commit in the fixes line moved multifd thread cre

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-29 Thread Avihai Horon
On 29/01/2024 6:17, Peter Xu wrote: External email: Use caution opening links or attachments On Sun, Jan 28, 2024 at 05:43:52PM +0200, Avihai Horon wrote: On 25/01/2024 22:57, Fabiano Rosas wrote: External email: Use caution opening links or attachments Avihai Horon writes: The commit

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-28 Thread Peter Xu
On Sun, Jan 28, 2024 at 05:43:52PM +0200, Avihai Horon wrote: > > On 25/01/2024 22:57, Fabiano Rosas wrote: > > External email: Use caution opening links or attachments > > > > > > Avihai Horon writes: > > > > > The commit in the fixes line moved multifd thread creation to a > > > different lo

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-28 Thread Avihai Horon
On 25/01/2024 22:57, Fabiano Rosas wrote: External email: Use caution opening links or attachments Avihai Horon writes: The commit in the fixes line moved multifd thread creation to a different location, but forgot to move the p->running = true assignment as well. Thus, p->running is set t

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-25 Thread Fabiano Rosas
Avihai Horon writes: > The commit in the fixes line moved multifd thread creation to a > different location, but forgot to move the p->running = true assignment > as well. Thus, p->running is set to true before multifd thread is > actually created. > > p->running is used in multifd_save_cleanup()

[PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-25 Thread Avihai Horon
The commit in the fixes line moved multifd thread creation to a different location, but forgot to move the p->running = true assignment as well. Thus, p->running is set to true before multifd thread is actually created. p->running is used in multifd_save_cleanup() to decide whether to join the mul