Re: [PATCH 04/24] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions

2021-10-28 Thread Warner Losh
On Thu, Oct 28, 2021 at 9:14 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 10/19/21 9:44 AM, Warner Losh wrote: > > +cpsr_write(env, regs->uregs[16], 0x, CPSRWriteRaw); > > This looks a bit suspicious. > Over in linux-user we use > > cpsr_write(env,

Re: [PATCH 04/24] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: +cpsr_write(env, regs->uregs[16], 0x, CPSRWriteRaw); This looks a bit suspicious. Over in linux-user we use cpsr_write(env, regs->uregs[16], CPSR_USER | CPSR_EXEC, CPSRWriteByInstr); Are you setting something special in

Re: [PATCH 04/24] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions

2021-10-23 Thread Kyle Evans
On Tue, Oct 19, 2021 at 11:45 AM Warner Losh wrote: > > target_arch_cpu.h is for CPU loop definitions. Create the file and > define target_cpu_init and target_cpu_reset for arm. > > Signed-off-by: Olivier Houchard > Signed-off-by: Stacey Son > Signed-off-by: Warner Losh > --- >

[PATCH 04/24] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions

2021-10-19 Thread Warner Losh
target_arch_cpu.h is for CPU loop definitions. Create the file and define target_cpu_init and target_cpu_reset for arm. Signed-off-by: Olivier Houchard Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_cpu.h | 42 ++ 1 file