Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-25 Thread Thomas Huth
On 24/02/2024 23.38, Paolo Bonzini wrote: On Fri, Feb 23, 2024 at 8:56 PM BALATON Zoltan wrote: -if (!lasi_dev && machine->enable_graphics) { +if (!lasi_dev && machine->enable_graphics && defaults_enabled()) { Do we need the defaults_enabled() here? Isn't enable_graphics already

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-24 Thread Paolo Bonzini
On Fri, Feb 23, 2024 at 8:56 PM BALATON Zoltan wrote: > >> -if (!lasi_dev && machine->enable_graphics) { > >> +if (!lasi_dev && machine->enable_graphics && defaults_enabled()) { > > > > Do we need the defaults_enabled() here? Isn't enable_graphics already > > disabled if

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-23 Thread Thomas Huth
On 23/02/2024 13.44, Paolo Bonzini wrote: With --without-default-devices it is possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as usb_create_simple can be

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-23 Thread BALATON Zoltan
On Fri, 23 Feb 2024, Thomas Huth wrote: On 23/02/2024 13.44, Paolo Bonzini wrote: With --without-default-devices it is possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-23 Thread Philippe Mathieu-Daudé
On 23/2/24 13:44, Paolo Bonzini wrote: With --without-default-devices it is possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as usb_create_simple can be inlined,

[PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-23 Thread Paolo Bonzini
With --without-default-devices it is possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as usb_create_simple can be inlined, this is not true of usb_bus_find().