Re: [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch

2021-05-14 Thread John Snow
On 5/14/21 10:42 AM, Wainer dos Santos Moschetta wrote: Hi, On 5/12/21 6:46 PM, John Snow wrote: Shift the open() call later so that the pylint pragma applies *only* to that one open() call. Add a note that suggests why this is safe: the resource is unconditionally cleaned up in _post_shutdown(

Re: [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch

2021-05-14 Thread Wainer dos Santos Moschetta
Hi, On 5/12/21 6:46 PM, John Snow wrote: Shift the open() call later so that the pylint pragma applies *only* to that one open() call. Add a note that suggests why this is safe: the resource is unconditionally cleaned up in _post_shutdown(). You can also put it in a pylint disable/enable bloc

[PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch

2021-05-12 Thread John Snow
Shift the open() call later so that the pylint pragma applies *only* to that one open() call. Add a note that suggests why this is safe: the resource is unconditionally cleaned up in _post_shutdown(). _post_shutdown is called after failed launches (see launch()), and unconditionally after every ca