Re: [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState

2022-12-27 Thread Alistair Francis
On Tue, Dec 27, 2022 at 4:55 PM Bin Meng wrote: > > At present for some unknown reason the HTIF registers (fromhost & > tohost) are defined in the RISC-V CPUArchState. It should really > be put in the HTIFState struct as it is only meaningful to HTIF. > > Signed-off-by: Bin Meng Reviewed-by: Ali

Re: [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState

2022-12-27 Thread Daniel Henrique Barboza
On 12/27/22 03:48, Bin Meng wrote: At present for some unknown reason the HTIF registers (fromhost & tohost) are defined in the RISC-V CPUArchState. It should really be put in the HTIFState struct as it is only meaningful to HTIF. Signed-off-by: Bin Meng --- Reviewed-by: Daniel Henrique Ba

[PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState

2022-12-26 Thread Bin Meng
At present for some unknown reason the HTIF registers (fromhost & tohost) are defined in the RISC-V CPUArchState. It should really be put in the HTIFState struct as it is only meaningful to HTIF. Signed-off-by: Bin Meng --- include/hw/char/riscv_htif.h | 8 target/riscv/cpu.h